Re: [PATCH] io: Fix silent readdir failures in ftw/nftw (BZ 33085)
Project / Subsystem
glibc / io
Date
2026-04-17
Proposer
DJ Delorie <[email protected]>
Source type
public_inbox
Consensus
Proposed
Sentiment
8/10
Technical tradeoffs
- • The patch adds error handling, increasing code complexity slightly.
- • Failing to free memory on error can lead to memory leaks, potentially destabilizing the application.
All attributes
- project
- glibc
- subsystem
- io
- patch_id
- —
- discussion_id
- [email protected]
- source_type
- public_inbox
- title
- Re: [PATCH] io: Fix silent readdir failures in ftw/nftw (BZ 33085)
- headline
- ftw/nftw: Add missing free() calls
- tldr
- Reviewers note that the proposed patch to fix silent readdir failures in ftw/nftw needs `free()` calls and has typos.
- stakes
- Fixes a bug where readdir failures were not properly signaled, potentially leading to unexpected behavior.
- proposer
- DJ Delorie <[email protected]>
- consensus
- Proposed
- outcome
- proposed
- sentiment_score
- 8
- sentiment_rationale
- The review is positive, pointing out necessary improvements.
- technical_tradeoffs
-
- • The patch adds error handling, increasing code complexity slightly.
- • Failing to free memory on error can lead to memory leaks, potentially destabilizing the application.
- series_id
- —
- series_role
- standalone
- series_parts
- []
- tags
-
- • io
- • ftw
- • nftw
- • readdir
- • memory leak
- bugzilla_url
- —
- date
- 2026-04-17T00:00:00.000Z
Re: [PATCH] io: Fix silent readdir failures in ftw/nftw (BZ 33085)
DJ Delorie reviews a patch from Adhemerval Zanella that fixes silent readdir failures in ftw/nftw. The review points out missing free() calls in the error handling paths and some typos in the test case.