Re: [PATCH 1/3] io: Consolidate fts implementation

Project / Subsystem

glibc / io

Date

2026-04-17

Proposer

Carlos O'Donell <[email protected]>

Source type

public_inbox

Consensus

Proposed

Sentiment

9/10

Technical tradeoffs

  • Reduces code duplication by consolidating implementations.
  • Simplifies maintenance by using a common implementation.
  • Removes arch-specific implementations where off_t and off64_t are the same.

All attributes

project
glibc
subsystem
io
patch_id
discussion_id
[email protected]
source_type
public_inbox
title
Re: [PATCH 1/3] io: Consolidate fts implementation
headline
io: Consolidate fts implementation
tldr
This patch consolidates the fts implementation by removing wordsize-64 and arch-specific implementations where off_t matches off64_t.
stakes
Reduces code duplication and simplifies maintenance of the fts implementation.
proposer
Carlos O'Donell <[email protected]>
consensus
Proposed
outcome
proposed
sentiment_score
9
sentiment_rationale
The patch is described as mechanical and has received explicit approval from upstream, suggesting a high level of confidence and agreement, pending confirmation of its origin.
technical_tradeoffs
  • Reduces code duplication by consolidating implementations.
  • Simplifies maintenance by using a common implementation.
  • Removes arch-specific implementations where off_t and off64_t are the same.
series_id
glibc:io: consolidate fts implementation
series_role
reply
series_parts
  • {"title":"io: Consolidate fts implementation","url":"https://inbox.sourceware.org/libc-alpha/[email protected]"}
  • {"title":"io: Consolidate fts implementation","url":"https://inbox.sourceware.org/libc-alpha/[email protected]"}
tags
  • io
  • fts
  • consolidation
  • code cleanup
bugzilla_url
date
2026-04-17T00:00:00.000Z

Re: [PATCH 1/3] io: Consolidate fts implementation

This patch consolidates the fts implementation by removing wordsize-64 and arch-specific implementations for ABIs where off_t is the same as off64_t. The fts.c implementation is moved to fts-common.c to simplify the __OFF_T_MATCHES_OFF64_T usage. Upstream has approved the patch and requests that it be pushed if it is a mechanical sync from gnulib.